----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57053/#review166773 -----------------------------------------------------------
Ship it! Ship It! - Oliver Szabo On Feb. 24, 2017, 10:50 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57053/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 10:50 p.m.) > > > Review request for Ambari, Miklos Gergely and Oliver Szabo. > > > Bugs: AMBARI-20190 > https://issues.apache.org/jira/browse/AMBARI-20190 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-20190. > > During some larger cluster testing with LogSearch, it was discovered that a > debugging message was logged at the ERROR level, and was logged repeatedly > (thousands of times in an 800-node cluster). > > This patch resolves this problem by implementing the following: > > 1. The ERROR message in question was moved to the DEBUG level, since it is > only generally useful in debugging situations for the integration layer. > 2. The message was also updated to include the host and component name for > the resource associated with the failure, as this could be useful in future > debugging sessions when certain components aren't available via LogSearch. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java > 36c485a > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java > 969d442 > > Diff: https://reviews.apache.org/r/57053/diff/ > > > Testing > ------- > > 1. Tested manually with a 3-node vagrant cluster, to verify that the updated > log message is only available at the DEBUG level, and also that the message > not includes the host and component names when DEBUG-level logging is turned > on. > 2. Currently running the ambari-server unit test suite, and will update the > review with the results. > > > Thanks, > > Robert Nettleton > >
