----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57080/#review166922 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Feb. 27, 2017, 6:56 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57080/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 6:56 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew > Onischuk, Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian > Toader. > > > Bugs: AMBARI-20196 > https://issues.apache.org/jira/browse/AMBARI-20196 > > > Repository: ambari > > > Description > ------- > > Ambari should install the unlimited key JCE policy based on service > requirements even if cluster is not Kerberized. For example, if a service > needs the unlimited key JCE policy for an encryption task not related to > Kerberos. > > On a similar note, the unlimited key JCE policy is not being distributed to > the agents if Kerberos is enabled using the "manual" option - as opposed to > integrating with an existing KDC. > > On a related note, Ambari Server host automatically unpacks JCE unlimited > during "ambari-server setup" (unless custom JDK is used). > > > Diffs > ----- > > ambari-agent/pom.xml 074e051 > ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java > PRE-CREATION > > ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > c80ebe6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 7cb7fce > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java > 51d9847 > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java > 409bcae > > ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py > ddc8063 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py > 5db62c5 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > 3f74aa7 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py > f21e4b1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 29c88b4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > 9783aa4 > > ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml > 3af8f08 > > ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/hook.py > f21e4b1 > > ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py > 455710b > > ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/shared_initialization.py > 5dce8e0 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py > 2ab700d > > ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java > 6e37ded > ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json > fa4cc9d > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py > 30561ac > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > 444fae6 > > Diff: https://reviews.apache.org/r/57080/diff/ > > > Testing > ------- > > Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and > OpenJDK 1.8. > > # Local test results: > ``` > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 28:49.548s > [INFO] Finished at: Mon Feb 27 12:50:22 EST 2017 > [INFO] Final Memory: 70M/613M > [INFO] > ------------------------------------------------------------------------ > ``` > > # Jenkins test results: > ``` > {color:green}+1 overall{color}. Here are the results of testing the latest > attachment > > http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch > against trunk revision . > > {color:green}+1 @author{color}. The patch does not contain any @author > tags. > > {color:green}+1 tests included{color}. The patch appears to include 4 > new or modified test files. > > {color:green}+1 javac{color}. The applied patch does not increase the > total number of javac compiler warnings. > > {color:green}+1 release audit{color}. The applied patch does not > increase the total number of release audit warnings. > > {color:green}+1 core tests{color}. The patch passed unit tests in > ambari-agent ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/10767//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/10767//console > ``` > > > Thanks, > > Robert Levas > >
