-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57201/
-----------------------------------------------------------
(Updated March 1, 2017, 7:16 p.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
Changes
-------
Increased the height of modal popup. Verified manually.
Bugs: AMBARI-20254
https://issues.apache.org/jira/browse/AMBARI-20254
Repository: ambari
Description
-------
AMBARI-19049 introduced some UI changes that causes regression in UX for the
Service Alert popup.
With the change, the user has to click on the expander to see any alert
context. And the expander UX is strange too. Clicking anywhere (including the
hyperlinked text as well as the background) in the header takes the user to the
alerts page. This is not the experience the user would expect based on
conventions.
The cases in which too much context is displayed and therefore needs special
handling is not the norm, so crippling UX for the special case is not the way
to go.
Diffs (updated)
-----
ambari-web/app/controllers/main/service/info/summary.js b3d7b35
ambari-web/app/models/alerts/alert_definition.js 4da7199
ambari-web/app/styles/alerts.less e31ea30
ambari-web/app/templates/main/service/info/service_alert_popup.hbs 6ab6b3f
Diff: https://reviews.apache.org/r/57201/diff/2/
Changes: https://reviews.apache.org/r/57201/diff/1-2/
Testing
-------
Verified Manually.
Ambari-web unit tests pass
20571 passing (19s)
153 pending
Thanks,
Vivek Ratnavel Subramanian
