-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57250/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and
Sandor Magyari.
Bugs: AMBARI-20270
https://issues.apache.org/jira/browse/AMBARI-20270
Repository: ambari
Description
-------
It is normal to have TopologyHostRequest entities with host name being null.
That indicates that the Blueprint processing is waiting for a host to join
Ambari server that matches the host request.
When a downscale is performed we iterate through in-memory host request object
collections to remove the ones that correspond to the host being removed from
the cluster. This logic is not prepared for host request with null host name
thus throwing NPE when comparing against the host name being removed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
0039e35
ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
ef4f615
Diff: https://reviews.apache.org/r/57250/diff/1/
Testing
-------
Manual testing with Blueprint + downscale.
Unit tests:
Results :
Tests run: 4936, Failures: 0, Errors: 0, Skipped: 39
Thanks,
Sebastian Toader
