----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57040/#review167814 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py Lines 349 (patched) <https://reviews.apache.org/r/57040/#comment239794> Maybe worth adding to the message that in case of very large clusters this operation may take hours or days to complete. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py Lines 351-353 (patched) <https://reviews.apache.org/r/57040/#comment239793> Wouldn't be enough just writing out "There is already a balancer running. Note that the process may take a long time to finish (hours, even days on very large clusters)." - Sebastian Toader On March 3, 2017, 9:52 a.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57040/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 9:52 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, > and Sebastian Toader. > > > Bugs: AMBARI-20175 > https://issues.apache.org/jira/browse/AMBARI-20175 > > > Repository: ambari > > > Description > ------- > > The rebalancing operation may take a long time (hours, days) thus when issued > from the ambari UI the background operation may time out. > As it's not possible to dynamically predict how long the rebalancing will > last , the approach taken by this solution is to only trigger the operation > and not wait to the operation to finish. > > (NOTE: after this change the progress of the rebalance operation won't be > tracked anymore in the background operation; also the user won't be notified > about the success/failure of the operation) > > UPDATE: > The operation is only triggered if there's no other rebalance operation > running. (This is done by checking the existence of the /system/balancer.id > on hdfs As per the input from hdfs devs, this check may be misleading if a > balancer process is killed by an admin, as the file can remain there. - To > overcome this added a message to explain this behavior) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py > 1dc545e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > 123486e > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f > > > Diff: https://reviews.apache.org/r/57040/diff/3/ > > > Testing > ------- > > Manually tested on local unsecure cluster. > Manually tested on local secure cluster > > Unit tests successfully ran. > > > Thanks, > > Laszlo Puskas > >
