-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/
-----------------------------------------------------------
(Updated March 3, 2017, 2:06 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
rename last page variable to lastPage
Bugs: AMBARI-20300
https://issues.apache.org/jira/browse/AMBARI-20300
Repository: ambari
Description
-------
If logs are deleted between the last screen generation and the clicking on the
last page button an empty table comes up. The same happens if the user clicks
on a page number which is no longer valid, as there are fewer logs since.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
d44b866
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
2dc0ef7
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
89873f3
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
f960250
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
c175397
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/TableLayout.js
1066510
Diff: https://reviews.apache.org/r/57287/diff/2/
Changes: https://reviews.apache.org/r/57287/diff/1-2/
Testing
-------
Tested on local cluster setting extra short time for the logs to expire.
Thanks,
Miklos Gergely
