The flag is in the ServiceDesiredState table which is not updated.

Get Outlook for iOS<https://aka.ms/o0ukef>




On Fri, Mar 3, 2017 at 9:47 AM -0800, "Jayush Luniya" 
<[email protected]<mailto:[email protected]>> wrote:

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/57253/


Maybe I am missing something, but what logic ensures that upgrading an existing 
cluster does not enable the credential store for already deployed services?


- Jayush Luniya


On March 2nd, 2017, 7:48 p.m. UTC, Madhuvanthi Radhakrishnan wrote:

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.
By Madhuvanthi Radhakrishnan.

Updated March 2, 2017, 7:48 p.m.

Bugs: AMBARI-20275<https://issues.apache.org/jira/browse/AMBARI-20275>
Repository: ambari
Description

Credential Store should be enabled by default on fresh installs (Hive, Oozie, 
Logsearch)


Testing

Manual Testing



Scenario - 1 FRESH INSTALL




Deploy Ambari 2.5 - HDP 2.6
0. Add services Hive, Oozie, Logsearch
1. GET http://<host>:8080/api/v1/clusters/cl1/services/HIVE  - Hive Credential 
Store enabled on fresh install
{
"href": "http://<host>:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
….
}
2. GET http://<host>:8080/api/v1/clusters/cl1/services/OOZIE - Oozie Credential 
Store enabled on fresh install
{
"href": "http://<host>:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
3. GET http://<host>:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch 
Credential Store enabled on fresh install
{
"href": "http://<host>:8080/api/v1/clusters/cl1/services/LOGSEARCH",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
4. User is able to disable Hive and Oozie CS
PUT 
http://<host>:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
{"ServiceInfo": {"credential_store_enabled": "false"}}




GET http://<host>:8080/api/v1/clusters/cl1/services/HIVE
{
"href": "http://<host>:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
…
}




PUT 
http://<host>:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
{"ServiceInfo": {"credential_store_enabled": "false"}}




GET http://<host>:8080/api/v1/clusters/cl1/services/OOZIE
{
"href": "http://<host>:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
….
}






  1.  User is not able to disable Logsearch
PUT 
http://<host>:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
{"ServiceInfo": {"credential_store_enabled": "false"}}
Response:
{
  "status" : 400,
  "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot 
disable credential store as it is required by the service. Service=LOGSEARCH"
}






Scenario - 1 AMBARI UPGRADE
1. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
   Hive, Oozie, Logsearch - disabled
2. User is able to enable Credential Store for Hive, Oozie, Logsearch post 
upgrade


Diffs

  *   
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
(245a94d)
  *   
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
(4230dd4)
  *   
ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
(75aa9d9)

View Diff<https://reviews.apache.org/r/57253/diff/1/>

Reply via email to