-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57334/#review167972
-----------------------------------------------------------


Ship it!




Ship It!

- Denys Buzhor


On March 6, 2017, 1 p.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57334/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 1 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20136
>     https://issues.apache.org/jira/browse/ambari-20136
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Breadcrumbs items should be defined in the routes.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 308edcd 
>   ambari-web/app/routes/main.js 4460442 
>   ambari-web/app/routes/view.js 50d8f4b 
>   ambari-web/app/routes/views.js 88b1251 
>   ambari-web/app/templates/application.hbs 9d6db78 
>   ambari-web/app/templates/common/breadcrumbs.hbs PRE-CREATION 
>   ambari-web/app/views.js 7ec59f7 
>   ambari-web/app/views/application.js ef9df6a 
>   ambari-web/app/views/common/breadcrumbs_view.js PRE-CREATION 
>   ambari-web/test/controllers/main/service/item_test.js e33ecaa 
>   ambari-web/test/views/common/breadcrumbs_view_test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57334/diff/1/
> 
> 
> Testing
> -------
> 
> 20576 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Reply via email to