-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57417/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,
Laszlo Puskas, and Sebastian Toader.
Bugs: AMBARI-20358
https://issues.apache.org/jira/browse/AMBARI-20358
Repository: ambari
Description
-------
Probably caused by this commit:
https://github.com/hortonworks/ambari/commit/6be4a18dd00f9d23d63410b748d67c952a6240c8
# STR
- Deploy HDP-2.3.6 with Ambari-2.2.2.0
- Upgrade Ambari to 2.5.0.1-13 (hash: 52b820b0c899a0246061c51245aca231c63583d7)
- this includes executing 'yum upgrade ambari-server' followed by
'ambari-server upgrade'
# Result
Error during DB schema upgrade
```
08 Mar 2017 04:52:22,059 INFO [main] AbstractUpgradeCatalog:609 - cluster
'cl1' changed by: 'ambari-upgrade'; type='ranger-kafka-security'
tag='version1488948741867' from='version1488942647954'
08 Mar 2017 04:52:23,469 INFO [main] UpgradeCatalog250:214 - Updating alert
definition hbase_master_cpu in cluster 2
08 Mar 2017 04:52:23,471 ERROR [main] SchemaUpgradeHelper:239 - Upgrade failed.
java.lang.NullPointerException
at
org.apache.ambari.server.upgrade.UpgradeCatalog250.fixHBaseMasterCPUUtilizationAlertDefinition(UpgradeCatalog250.java:229)
at
org.apache.ambari.server.upgrade.UpgradeCatalog250.executeDMLUpdates(UpgradeCatalog250.java:197)
at
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:952)
at
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:237)
at
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:430)
08 Mar 2017 04:52:23,474 ERROR [main] SchemaUpgradeHelper:443 - Exception
occurred during upgrade, failed
org.apache.ambari.server.AmbariException
at
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:240)
at
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:430)
Caused by: java.lang.NullPointerException
at
org.apache.ambari.server.upgrade.UpgradeCatalog250.fixHBaseMasterCPUUtilizationAlertDefinition(UpgradeCatalog250.java:229)
at
org.apache.ambari.server.upgrade.UpgradeCatalog250.executeDMLUpdates(UpgradeCatalog250.java:197)
at
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:952)
at
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:237)
... 1 more
08 Mar 2017 04:52:27,829 INFO [main] Configuration:2906 - Reading password
from existing file
08 Mar 2017 04:52:27,863 INFO [main] Configuration:3382 - Hosts Mapping File
null
08 Mar 2017 04:52:27,864 INFO [main] HostsMap:60 - Using hostsmap file null
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
b32e374
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
d1f8682
Diff: https://reviews.apache.org/r/57417/diff/1/
Testing
-------
Manually tested Ambari upgrade (`ambari-server upgrade`) on DB from Ambari 2.2.2
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas