----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57477/#review168528 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py Lines 238 (patched) <https://reviews.apache.org/r/57477/#comment240771> Rename to serverCall1 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py Lines 247 (patched) <https://reviews.apache.org/r/57477/#comment240770> Looks like a type "pwdU" - Sid Wagle On March 9, 2017, 9:44 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57477/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 9:44 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-20385 > https://issues.apache.org/jira/browse/AMBARI-20385 > > > Repository: ambari > > > Description > ------- > > Grafana stores the cluster admin credentails in plain text form at > /etc/ambari-metrics-grafana/conf/ams-grafana.ini > > FIX > Remove Plaintext password entry from ams-grafana-ini. > Check if current password works. If it does not, use Grafana API to set > password, assuming 'admin' as the default password. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 00d1c31 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml > da4599e > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > 4ff3191 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > 8fcf755 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 1a87433 > > > Diff: https://reviews.apache.org/r/57477/diff/1/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
