----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/#review168620 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On March 10, 2017, 8:53 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57506/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 8:53 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-20394 > https://issues.apache.org/jira/browse/AMBARI-20394 > > > Repository: ambari > > > Description > ------- > > No Content-Type HTTP header is set when downloading woff or ttf files. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > a2441bd > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java > 85c47fc > > > Diff: https://reviews.apache.org/r/57506/diff/2/ > > > Testing > ------- > > tested with curl: > curl -vv --user admin:admin --insecure > https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.woff?v=3.2.1 > curl -vv --user admin:admin --insecure > https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.ttf > > > existing unittests ran with one irrelevant error: > > ---------------------------------------------------------------------- > Failed tests: > ERROR: test_start (test_metrics_grafana.TestMetricsGrafana) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py", > line 1199, in patched > return func(*args, **keywargs) > File > "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py", > line 47, in test_start > target = RMFTestCase.TARGET_COMMON_SERVICES > File > "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", > line 155, in executeScript > method(RMFTestCase.env, *command_args) > File > "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py", > line 58, in start > create_grafana_admin_pwd() > File > "/Users/amagyar/development/ambari/ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py", > line 230, in create_grafana_admin_pwd > host = params.ams_grafana_host.strip(), > AttributeError: 'NoneType' object has no attribute 'strip' > > > Thanks, > > Attila Magyar > >
