----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57525/#review168781 -----------------------------------------------------------
Ship it! Ship It! - Alexandr Antonenko On March 11, 2017, 12:41 a.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57525/ > ----------------------------------------------------------- > > (Updated March 11, 2017, 12:41 a.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-20402 > https://issues.apache.org/jira/browse/AMBARI-20402 > > > Repository: ambari > > > Description > ------- > > Ambari install wizard seems to give recommendations that are not in line with > best practices by default. Furthermore, if you make any change to the master > node assignments and then undo it, the recommended configuration seems to > change and appears correct. This happens because the initial call to get > stack advisor recommendations is made before UI elements have been fully > populated on Assign Masters page. As a result, the recommendations returned > do not take into account the host configuration. Recommendations are fetched > again after UI elements are fully rendered, but because there are existing > recommendations, the AJAX call is not made (this check has been put in to > avoid repetitive AJAX calls while user moves back and forth between Assign > Masters and Assign Slaves and Clients page). > > Fix is to add a new flag to track the case where user navigates between Step > 5 and 6. Only for that specific case, we will not make the AJAX call. If any > configuration changes are made however, recommendations are reset and the > AJAX call is made again as required. > > Build failure is unrelated to the patch. I was able to apply the patch > successfully to latest 2.5 code and build and test successfully. > > > Diffs > ----- > > ambari-web/app/mixins/wizard/assign_master_components.js 60c6eeb > > > Diff: https://reviews.apache.org/r/57525/diff/1/ > > > Testing > ------- > > Manual Tests. > Ran mvn clean test > > > 30367 passing (41s) > 157 pending > > > Thanks, > > Sangeeta Ravindran > >
