----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57625/#review169072 -----------------------------------------------------------
drwxr-xr-x 755 `/var/lib/ambari-server/keys/db/newcerts' Do you agree to change permissions for secure directories to recommended 700 [y/n] (y)? 1. We are putting quotes around the directory/file in question in a weird way. The initial quote is a backtick and the closing quote is a single quote. Let's just drop the quotes all together. I don't think the quotes add much value / clarity / readability. 2. Can we change the prompt a little bit, like this: "Fix permissions for XXX to YYY (recommended) [y/n] (y)?" - Yusaku Sako On March 14, 2017, 10:35 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57625/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 10:35 p.m.) > > > Review request for Ambari, Robert Levas, Sumit Mohanty, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-20453 > https://issues.apache.org/jira/browse/AMBARI-20453 > > > Repository: ambari > > > Description > ------- > > Minor refactoring and clean up in ambari-server > > > Diffs > ----- > > ambari-server/src/main/assemblies/server.xml 768ba68 > > ambari-server/src/main/java/org/apache/ambari/server/security/CertificateManager.java > 8d54acb > ambari-server/src/main/package/rpm/postinstall.sh 1e8e0f0 > ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py 188f3ff > ambari-server/src/main/python/ambari_server/serverConfiguration.py 3dd165b > ambari-server/src/main/resources/scripts/check_ambari_permissions.py > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57625/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
