----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/ -----------------------------------------------------------
(Updated March 16, 2017, 12:49 p.m.) Review request for Ambari and Jaimin Jetly. Changes ------- Extra patch added Bugs: ambari-20388 https://issues.apache.org/jira/browse/ambari-20388 Repository: ambari Description ------- - Create a custom config group for a service - Update few properties and save to get a version for this custom group - Add another property and save just to generate more config version - Compare these 2 versions. Usually diff shows only the values from compared versions - But looks like it shows the current value and the values in each version as well. - In default group we dont see that extra line with the current value. Diffs (updated) ----- ambari-web/app/controllers/main/service/info/configs.js 786c6f9 ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4 ambari-web/app/templates/common/configs/service_config_category.hbs 9890525 ambari-web/app/views/common/controls_view.js 4bd4a61 Diff: https://reviews.apache.org/r/57507/diff/2/ Changes: https://reviews.apache.org/r/57507/diff/1-2/ Testing ------- 20559 passing (23s) 153 pending Thanks, Oleg Nechiporenko