> On March 15, 2017, 11:23 a.m., Nate Cole wrote: > > LGTM, make sure you get a UI person to take a look. > > wang jianfei wrote: > OK, thanks very much! By the way, can you recommend some UI persons for > me?
Possibly jaimin? - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57589/#review169015 ----------------------------------------------------------- On March 14, 2017, 4:01 a.m., wang jianfei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57589/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 4:01 a.m.) > > > Review request for Ambari, Abhishek Kumar, Aleksandr Kovalenko, Gaurav Nagar, > Nate Cole, and Rohit Choudhary. > > > Bugs: AMBARI-20438 > https://issues.apache.org/jira/browse/AMBARI-20438 > > > Repository: ambari > > > Description > ------- > > PROBLEM: > When you duplicate alert group in the dialog of Manage Alert Groups,the new > copied alert group just shows the global notifications rather than all > notifications of the origin alert group. > > BUG&FIX: > Make it duplicate all the alert notifications of the origin alert group > rather than duplicate only the global notifications. > > > Diffs > ----- > > ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js > db65b2a > > > Diff: https://reviews.apache.org/r/57589/diff/1/ > > > Testing > ------- > > DONE. > > > Thanks, > > wang jianfei > >
