> On March 16, 2017, 3:01 p.m., Robert Nettleton wrote: > > Patch looks fine to me, although it would be good to add a unit test for > > the change to the Blueprint config processor. > > > > I'd also recommend one additional manual test: Deploy a Blueprint with the > > default configuration recommendation strategy (which is "NEVER_APPLY" when > > not set in the Cluster Creation template). This test will verify that the > > property updater functions properly and sets the expected host name in this > > property even when the StackAdvisor is not consulted, which is the default > > behavior. > > > > Thanks for providing this patch!
Tested with NEVER_APPLY and verified that it still replaces the %HOST correctly. > On March 16, 2017, 3:01 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > > Lines 2492 (patched) > > <https://reviews.apache.org/r/57672/diff/1/?file=1665879#file1665879line2492> > > > > It would probably be a good idea to add a unit test to verify that this > > property updater is registered as expected. I am providing an addendum patch and attaching it to the apache jira itself. Thank you - Madhuvanthi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57672/#review169159 ----------------------------------------------------------- On March 16, 2017, 12:21 a.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57672/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 12:21 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert > Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-20469 > https://issues.apache.org/jira/browse/AMBARI-20469 > > > Repository: ambari > > > Description > ------- > > Add a new property to yarn-site.xml yarn.log.server.web-service.url > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > e604598 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml > 4b97148 > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 0968d8b > > > Diff: https://reviews.apache.org/r/57672/diff/1/ > > > Testing > ------- > > 1. Fresh Install : HDP 2.6 > Install Yarn. Check if the yarn.log.server.web-service.url is appropriately > set i.e if policy = HTTP_ONLY, then the value is > http://${yarn.resourcemanager.webapp.address}/ws/v1/applicationhistory > Change the policy to HTTPS_ONLY, the UI will show a warning on Save Configs > to change the yarn.log.server.web-service.url to > https://${yarn.resourcemanager.webapp.https.address}/ws/v1/applicationhistory > > 2. Export Blueprint > yarn.log.server.web-service.url = > "http://%HOSTGROUP::host_group_2%:8188/ws/v1/applicationhistory";, > > 3. Deploy a cluster using Blueprint > config_recommendation_strategy = ONLY_STACK_DEFAULTS_APPLY > "yarn.log.server.web-service.url": > "http://c6402.ambari.apache.org:8188/ws/v1/applicationhistory";, > where: > yarn.timeline-service.webapp.address": "c6402.ambari.apache.org:8188", > > > Thanks, > > Madhuvanthi Radhakrishnan > >
