----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57703/#review169224 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py Lines 466 (patched) <https://reviews.apache.org/r/57703/#comment241563> The if should first check the policy value, and then decide if the non-https or https config needs to exist. This could cause a bug if http is used but the https config doesn't exist. ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py Lines 1769 (patched) <https://reviews.apache.org/r/57703/#comment241564> Let's be robust and use default("...", None) and explicitly check for == "HTTP" or == "HTTPS" - Alejandro Fernandez On March 16, 2017, 9:08 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57703/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 9:08 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-20469 > https://issues.apache.org/jira/browse/AMBARI-20469 > > > Repository: ambari > > > Description > ------- > > Add a new property to yarn-site.xml yarn.log.server.web-service.url > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml > dd5e9a4 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py > 4fdf84f > > > Diff: https://reviews.apache.org/r/57703/diff/2/ > > > Testing > ------- > > From https://reviews.apache.org/r/57672/ > > > Thanks, > > Madhuvanthi Radhakrishnan > >
