----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57770/#review169403 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On March 20, 2017, 10:07 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57770/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 10:07 a.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Laszlo Puskas, and Sebastian Toader. > > > Bugs: AMBARI-20494 > https://issues.apache.org/jira/browse/AMBARI-20494 > > > Repository: ambari > > > Description > ------- > > Disabling security is failing with : > ``` > Stack Advisor reported an error: AttributeError: 'NoneType' object has no > attribute 'replace' > StdOut file: /var/run/ambari-server/stack-recommendations/26/stackadvisor.out > > StdErr file: /var/run/ambari-server/stack-recommendations/26/stackadvisor.err > ``` > > Error file shows : > ``` > Traceback (most recent call last): > File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 166, > in <module> > main(sys.argv) > File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 116, > in main > result = stackAdvisor.recommendConfigurations(services, hosts) > File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", > line 775, in recommendConfigurations > calculation(configurations, clusterSummary, services, hosts) > File > "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py", > line 480, in recommendStormConfigurations > storm_nimbus_impersonation_acl.replace('{{storm_bare_jaas_principal}}', > storm_bare_jaas_principal) > AttributeError: 'NoneType' object has no attribute 'replace' > ``` > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 13151eb > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 693b067 > > > Diff: https://reviews.apache.org/r/57770/diff/1/ > > > Testing > ------- > > Manually tested > > # Local test results: > ``` > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:15.026s > [INFO] Finished at: Sat Mar 18 21:16:02 EDT 2017 > [INFO] Final Memory: 71M/1372M > [INFO] > ------------------------------------------------------------------------ > ``` > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
