----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57795/#review169517 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py Line 79 (original), 79 (patched) <https://reviews.apache.org/r/57795/#comment241876> Small nitpick, put a space after the comma - Alejandro Fernandez On March 20, 2017, 10:02 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57795/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 10:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit > Mohanty. > > > Bugs: AMBARI-20512 > https://issues.apache.org/jira/browse/AMBARI-20512 > > > Repository: ambari > > > Description > ------- > > the archive.zip and .hash is not getting generated on the server side when > the package folder is under > stacks/<stack-name>/<stack-version>/services/<service-name>/package > instead of common-services/<service-name>/<service-version>/package > On closer look, the issue was that when the directories are being traversed > to look for hooks and package folders that need to be hashed/archived for > having it in the agent cache, those directories that were symlinks were being > skipped. > Fix is to include them. > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179 > > > Diff: https://reviews.apache.org/r/57795/diff/1/ > > > Testing > ------- > > Tested using a management pack > > > Thanks, > > Madhuvanthi Radhakrishnan > >
