> On March 22, 2017, 2:23 p.m., Jaimin Jetly wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > > Line 230 (original), 230 (patched) > > <https://reviews.apache.org/r/57771/diff/2/?file=1670286#file1670286line230> > > > > How will user interface behave when jce policy is not required ? > > Instead of host resource rest api exposing a boolean, does it makes > > sense to have enum "INSTALLED", "NOT_INSTALLED" and "NOT_REQUIRED"?
I think there are a few different usages here. 1) The code in shared_initialization.py is used to contionally install the unlimited JCE policy if required. Logic in the Ambari server determines whether it is required or not based on service metadata and whether Kerberos is enabled or not. This was handled in https://issues.apache.org/jira/browse/AMBARI-20196. Attila needed to update the class used to invoke the utility that is used to determine when the unlimited key JCE policy was installed or not. 2) The task at hand is to collect information from each host in the cluster to know whether the unlimited key JCE policy has been installed or not - regardless of whether it is required or not. This is for informational purposes only to make it easier for a user to get more info about the hosts. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57771/#review169757 ----------------------------------------------------------- On March 22, 2017, 5:44 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57771/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 5:44 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Robert Levas, and > Sebastian Toader. > > > Bugs: AMBARI-20525 > https://issues.apache.org/jira/browse/AMBARI-20525 > > > Repository: ambari > > > Description > ------- > > In many cases support engineers want to look at if Unlimited Strength Java > Cryptography Extension is installed on all hosts quickly and easily. > > This information is now visible on the host summary page, and can be accessed > via api call: /api/v1/hosts?fields=Hosts/last_agent_env. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 7f041eb > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 67294e0 > > ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py > a4e4f6e > ambari-server/src/main/java/org/apache/ambari/server/agent/AgentEnv.java > 64d0865 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 20431f6 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > 3c36962 > > ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/shared_initialization.py > 71161e0 > > ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java > 3f62366 > ambari-web/app/controllers/global/update_controller.js 59eaf3e > ambari-web/app/mappers/hosts_mapper.js e4dd08f > ambari-web/app/messages.js c9926e6 > ambari-web/app/models/host.js 1b7b326 > ambari-web/app/templates/main/host/summary.hbs 5d0b09c > > > Diff: https://reviews.apache.org/r/57771/diff/2/ > > > Testing > ------- > > added new unittests, tested the UI manually > > existing tests ran successfully with one irrelevant exception: > > ====================================================================== > FAIL: test_get_params_from_filesystem > (TestSecurityCommons.TestSecurityCommons) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py", > line 1199, in patched > return func(*args, **keywargs) > File > "/Users/amagyar/development/ambari/ambari-agent/src/test/python/resource_management/TestSecurityCommons.py", > line 203, in test_get_params_from_filesystem > et_parser_mock.assert_called_with(conf_dir + os.sep + "config.xml") > File > "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py", > line 829, in assert_called_with > raise AssertionError('Expected call: %s\nNot called' % (expected,)) > AssertionError: Expected call: > parse('/var/folders/hp/5rnr2yx14q7csg8xbtp_mkr80000gn/T/config.xml') > Not called > > ---------------------------------------------------------------------- > Ran 465 tests in 16.659s > > > Thanks, > > Attila Magyar > >
