> On March 22, 2017, 2:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > > Lines 296 (patched) > > <https://reviews.apache.org/r/57792/diff/2/?file=1670562#file1670562line342> > > > > Doesn't this mean split the original set into subsets of 1 each? When > > `numHostsPerBatch` is 0, then you should have a single set of all hosts, > > right? Why not just use a Collections.singleontList(hostNames)
You're right, should run in parallel by adding the existing hostnames set into the list. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/#review169707 ----------------------------------------------------------- On March 23, 2017, 12:08 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57792/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 12:08 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-20490 > https://issues.apache.org/jira/browse/AMBARI-20490 > > > Repository: ambari > > > Description > ------- > > On large-scale clusters over 1000 nodes, performance during Express Upgrade > can be very slow and it takes more time to fix potential errors. > We can remedy these with the following fixes: > > * "hdp-select set all" is currently ran in the ClusterGroup with a single > stage instead of batching. This can cause Ambari Server to be the bottleneck > when processing 1000+ requests. Allow the execute-stage inside a ClusterGroup > to use batching. > > * If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it > will prevent the hosts from running "hdp-select versions". We can find these > problematic hosts with an alert. > > * There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a > 2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no > longer supported in Ambari 2.5). > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 513ceac > > ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java > 8556436 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d37e32b > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 3a2dc89 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 80bb26c > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > be1f469 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java > 6004a12 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java > 86a8f55 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java > ec7279c > ambari-server/src/main/resources/alerts.json 9cffff5 > ambari-server/src/main/resources/host_scripts/alert_version_select.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > 0f5f48e > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > 46f0fee > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > a741722 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml > 933183b > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.5.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 90f62dc > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > ecfc4d7 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 68fb1d4 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > 2e5c60e > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 4e49097 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > 3107bf3 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 538fa48 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 1ea9407 > > ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java > f5ce11e > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml > bfd994e > > > Diff: https://reviews.apache.org/r/57792/diff/4/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Alejandro Fernandez > >
