----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/#review169859 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On March 22, 2017, 7:58 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57863/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 7:58 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit > Mohanty. > > > Bugs: AMBARI-20536 > https://issues.apache.org/jira/browse/AMBARI-20536 > > > Repository: ambari > > > Description > ------- > > get_port_from_url function parses an port only address incorrectly. > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py > 48e0aa0 > > ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py > 7ff2a14 > > > Diff: https://reviews.apache.org/r/57863/diff/2/ > > > Testing > ------- > > Reproduced with the alert being shown as "Connection refused for > http://<host>:80/node/info > With the fix, the alert did not appear. > > Ran python tests. > Also checked for an empty hive.metastore.uri property and it allowed the > value as per the fix for AMBARI-20427 > > > Thanks, > > Madhuvanthi Radhakrishnan > >
