----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57874/#review169866 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java Line 47 (original), 47 (patched) <https://reviews.apache.org/r/57874/#comment242576> Please add `<>` ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java Line 50 (original), 50 (patched) <https://reviews.apache.org/r/57874/#comment242577> `== null` cannot be true here. - Attila Doroszlai On March 23, 2017, 2:29 p.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57874/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 2:29 p.m.) > > > Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian > Toader. > > > Bugs: AMBARI-20542 > https://issues.apache.org/jira/browse/AMBARI-20542 > > > Repository: ambari > > > Description > ------- > > Problem: > When validating config types posted in the blueprint and cluster template > need to be checked against config types for services in the blueprint > available in the stack. > Previously only config types in the cluster template were considered during > the validation. > > Solution > All the config types are taken into account during the above validation, by > calling the appropriate internal api. > > Note: > A bug has also been corrected in finding valid/invalid config types. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java > 18d08b9 > > ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java > 24fa8b8 > > > Diff: https://reviews.apache.org/r/57874/diff/1/ > > > Testing > ------- > > Manually on local env. > Unit tests written. > > > Thanks, > > Laszlo Puskas > >
