----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/#review169873 -----------------------------------------------------------
Ship it! Ship It! - Andrii Babiichuk On Березень 23, 2017, 3:22 після полудня, Aleksandr Kovalenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57858/ > ----------------------------------------------------------- > > (Updated Березень 23, 2017, 3:22 після полудня) > > > Review request for Ambari, Andrii Babiichuk and Jaimin Jetly. > > > Bugs: AMBARI-20535 > https://issues.apache.org/jira/browse/AMBARI-20535 > > > Repository: ambari > > > Description > ------- > > Instead of having two different steps for "Configure Services" and "Configure > Identities", we should have configuring identities properties overlaid on > "Configure Services" page. > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 > ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c > ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f > ambari-web/app/controllers/main/service/add_controller.js 0989f76 > ambari-web/app/controllers/wizard.js 7af9ab0 > ambari-web/app/controllers/wizard/step7_controller.js 0207e6b > ambari-web/app/controllers/wizard/step8_controller.js efd8834 > ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a > ambari-web/app/routes/add_kerberos_routes.js f556acb > ambari-web/app/routes/add_service_routes.js 9ff0b10 > ambari-web/app/templates/main/service/add.hbs 2873a87 > ambari-web/app/utils/ajax/ajax.js b63027e > ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js > 422ac26 > ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 > ambari-web/test/controllers/wizard/step7_test.js d5d157d > ambari-web/test/controllers/wizard/step8_test.js bdc4f4c > > > Diff: https://reviews.apache.org/r/57858/diff/3/ > > > Testing > ------- > > 20604 passing (24s) > 128 pending > > > Thanks, > > Aleksandr Kovalenko > >
