----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57892/#review169928 -----------------------------------------------------------
Sorry, the initial json file I provided had some hosts selected and auto-refresh was enabled. I think that led to many irrelevant changes. Only required changes are - Removal of IOMetrics from third row - JVM metrics moved from fourth to third row - Offheap metrics is added as fourth row Any other changes not related to the above can be reverted. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json Line 38 (original), 38 (patched) <https://reviews.apache.org/r/57892/#comment242637> We can reset it back to false. This change is also not relevant/required. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json Line 99 (original), 99 (patched) <https://reviews.apache.org/r/57892/#comment242636> I think this creeped in because of the manual edit because I sent the initial json with some hosts selected. This change is not required and can be reverted back to "" ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json Line 253 (original), 253 (patched) <https://reviews.apache.org/r/57892/#comment242638> All these "%" can be reverted back. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json Line 1995 (original) <https://reviews.apache.org/r/57892/#comment242640> This also is not required and can be reverted. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json Line 1997 (original), 2145 (patched) <https://reviews.apache.org/r/57892/#comment242639> Not sure why this version changed. - Prasanth_J On March 23, 2017, 8:59 p.m., Vivek Ratnavel Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57892/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 8:59 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Jaimin Jetly, Prasanth_J, and > Yusaku Sako. > > > Bugs: AMBARI-20548 > https://issues.apache.org/jira/browse/AMBARI-20548 > > > Repository: ambari > > > Description > ------- > > Few new metrics (Offheap memory metrics) got added to llap recently which > will be critical for debugging. Also some old metrics in dashboard are not > really useful which can be removed (Llap IO Metrics). > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json > 2f69868 > > > Diff: https://reviews.apache.org/r/57892/diff/1/ > > > Testing > ------- > > Verified Manually. > > > Thanks, > > Vivek Ratnavel Subramanian > >
