----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57872/#review170034 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py Lines 312 (patched) <https://reviews.apache.org/r/57872/#comment242775> do, for settings_key,interpreter in interpreter_settings.itemitems(): ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py Lines 314 (patched) <https://reviews.apache.org/r/57872/#comment242773> Can remove parentheses and do "not in " ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py Lines 315 (patched) <https://reviews.apache.org/r/57872/#comment242776> Not a good idea to delete keys from the dictionary while iterating over it. Create a list of keys to delete - Alejandro Fernandez On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57872/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 11:26 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20539 > https://issues.apache.org/jira/browse/AMBARI-20539 > > > Repository: ambari > > > Description > ------- > > Interpreters that are not listed under "zeppelin.interpreter.group.order" in > zeppelin-site.xml should not get installed and get configured. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml > 039c701 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 38bfeb4 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 0a0acdb > ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce > > > Diff: https://reviews.apache.org/r/57872/diff/1/ > > > Testing > ------- > > Manually on CentOS6 > > > Thanks, > > Prabhjyot Singh > >
