-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57961/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-20589
https://issues.apache.org/jira/browse/AMBARI-20589
Repository: ambari
Description
-------
1. Optimize string constants definition in admin-web so that they are easier
searchable by key.
2. Remove hardcoded strings from views and controllers in favor of constants
where necessary.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/authentication/AuthenticationMainCtrl.js
bce9189
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js
ff255ef
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ExportBlueprintCtrl.js
a1e4fa0
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
5dc6bd3
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
c61e71c
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/LoginMessageMainCtrl.js
911bb0b
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js
3656dfc
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
2990cef
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js
dcb7418
ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js
694a7bd
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js
61420c0
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js
3345b0b
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js
64abd9d
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html
418c115
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/modals/create.html
e13f84c
ambari-admin/src/main/resources/ui/admin-web/app/views/authentication/main.html
57ba7c9
ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html
3729e7d
ambari-admin/src/main/resources/ui/admin-web/app/views/groups/create.html
041a228
ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/loginMessage.html
9dbc23f
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddRepositoryModal.html
a439bde
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddVersionModal.html
993cef5
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
c3ad9e7
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html
bdecbdc
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html
db869f2
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html
58326aa
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
b31e2c5
ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html
87e2be7
Diff: https://reviews.apache.org/r/57961/diff/1/
Testing
-------
Executed 81 of 81 SUCCESS (0.553 secs / 0.548 secs)
Thanks,
Andrii Babiichuk
