> On March 28, 2017, 10:16 a.m., DIPAYAN BHOWMICK wrote: > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > > Lines 304 (patched) > > <https://reviews.apache.org/r/57979/diff/1/?file=1677329#file1677329line304> > > > > Take this out in a separate class. The logic of retrieving the values > > should not be here. A Factory sort of which takes a databaseMetaData object > > and returns a DatabaseMetadataWrapper object.
fix it and ship it. - DIPAYAN ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170288 ----------------------------------------------------------- On March 27, 2017, 11:29 p.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57979/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 11:29 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20598 > https://issues.apache.org/jira/browse/AMBARI-20598 > > > Repository: ambari > > > Description > ------- > > added support for stats of partitioned table > for hive server version 2.1 and above > > > Diffs > ----- > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java > f3c4e91e0b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java > 5cc60fbb75 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 45fc786a38 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > c3ed14b2a3 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java > 5b5e17c38d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java > f8c3ba0fb4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java > baa82b4d12 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java > ef4f100ab1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java > 190ecd36cb > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java > 3048d22190 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java > aae23c8ba8 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java > f2a1933d98 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java > 0c93ba31c5 > > contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js > 0310cbc005 > contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js > 620bf9b61b > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs > 5f62fca4e7 > > > Diff: https://reviews.apache.org/r/57979/diff/1/ > > > Testing > ------- > > manual testing done for hive 2.1 and hive 1.2 for partitioned and non > partitioned tables. > > > Thanks, > > Nitiraj Rathore > >
