----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58002/#review170340 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java Lines 161 (patched) <https://reviews.apache.org/r/58002/#comment243141> Are these all removed services, or only the ones that participate in the orchestration? What happens if a service, say AMS or SmartSense is dropped from the stack, doesn't participate in EU/RU? Then the PreChecks shouldn't fail because of it. - Alejandro Fernandez On March 28, 2017, 8:04 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58002/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 8:04 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-20592 > https://issues.apache.org/jira/browse/AMBARI-20592 > > > Repository: ambari > > > Description > ------- > > ServicePresence check currently checks the following two cases > 1. services that do not support upgrade, and must be reinstalled post EU/RU > 2. services replaced by other services in the new release, where the old > service must be dropped before EU/RU, and the replacement can be added post > the stack upgrade. > The JIRA is to add one more use case to the check, that;s to check for > services dropped from the new release (end of life) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 71c5857 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java > 4642b88 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicePresenceCheckTest.java > 03b0e81 > > > Diff: https://reviews.apache.org/r/58002/diff/1/ > > > Testing > ------- > > unit tests > patch Ambari trunk cluster, update upgrade.xml to include for example YARN as > a removed service, run EU/RU, verify precheck fails and couldn't proceed > (expected) > > > Thanks, > > Di Li > >
