----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58019/#review170436 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On March 29, 2017, 8:57 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58019/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 8:57 a.m.) > > > Review request for Ambari, Andrew Onischuk, Nate Cole, and Siddharth Seth. > > > Bugs: AMBARI-20617 > https://issues.apache.org/jira/browse/AMBARI-20617 > > > Repository: ambari > > > Description > ------- > > Makes debugging quite a bit easier. Without the log level - there's no way of > knowing if stack-advisor ran into an error, from the ambari-server log. > > Method name is helpful. Also the log line, depending on the cost. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py > a37ebc67 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py > 9ced5f1 > > ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/service_advisor.py > 6122f14 > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/service_advisor.py > ee803b0 > > ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/service_advisor.py > cc84cc4 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py > 103b934 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py > 4174b9c > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py > 6ef74d2 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 68026d6 > ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py > 81c9b72 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 800edbe > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 781ff13 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > b693f9f > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 53ff007 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py > c7d9327 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > a3d9598 > ambari-server/src/main/resources/stacks/PERF/1.0/services/stack_advisor.py > 43d417e > ambari-server/src/main/resources/stacks/stack_advisor.py 975a8f7 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/stack_advisor.py > 7a1e6bd > > > Diff: https://reviews.apache.org/r/58019/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
