> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote: > > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > > Lines 203 (patched) > > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203> > > > > Why is this commented out? > > Madhuvanthi Radhakrishnan wrote: > The fix, > if name != 'metastore': > XmlConfig("mapred-site.xml", > skips the mapred-site.xml resource for hive-metastore so this test was > failing that resource not found. But that is expected so I thought we would > not need this test anymore. > > Jayush Luniya wrote: > But we should remove the deadcode and not comment it out right? > > Madhuvanthi Radhakrishnan wrote: > I will fix that. Thanks
+1 to remove deadcode - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/#review170595 ----------------------------------------------------------- On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58031/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 11:57 p.m.) > > > Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-20615 > https://issues.apache.org/jira/browse/AMBARI-20615 > > > Repository: ambari > > > Description > ------- > > HMS does not require mapred configs so we need to add a condition so that HMS > can be deployed without yarn > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 5f566174b8 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > b7b04a2095 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > 2ed3e3a26a > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py > b7b04a2095 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py > 2ed3e3a26a > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py > 9486e11e46 > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > a159cd0370 > > > Diff: https://reviews.apache.org/r/58031/diff/3/ > > > Testing > ------- > > Deployed a single node cluster using HMS-Zookeeper only blueprint. > Deployed a regular cluster and added hive service wih existing mysql. > Verified that no regression occurs. > Run python unit tests. > > > Thanks, > > Madhuvanthi Radhakrishnan > >
