----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58045/#review170630 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On March 29, 2017, 8:23 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58045/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 8:23 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-20623 > https://issues.apache.org/jira/browse/AMBARI-20623 > > > Repository: ambari > > > Description > ------- > > Generating swgger.yaml shows some errors regarding to the rest api docs: > - top path param is not used properly in some cases > - id path param is not used/read on userconfig rest api endpoint > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/FieldAuditLogRequestQueryConverter.java > a4e613b > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/TopFieldAuditLogRequestQueryConverter.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java > 49465d5 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/request/impl/FieldAuditLogRequest.java > 0bdcddf > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/request/impl/TopFieldAuditLogRequest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java > 2013dc7 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java > 19cfbed > > ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/converter/FieldAuditLogRequestQueryConverterTest.java > 08541e1 > > ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/converter/TopFieldAuditLogRequestQueryConverterTest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/main/webapp/scripts/views/common/Header.js > deb0e28 > > > Diff: https://reviews.apache.org/r/58045/diff/1/ > > > Testing > ------- > > done. generated yaml/json do not show errors > > > Thanks, > > Oliver Szabo > >
