----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58083/#review170684 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On March 30, 2017, 6 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58083/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 6 p.m.) > > > Review request for Ambari, Laszlo Puskas, Sandor Magyari, and Sebastian > Toader. > > > Bugs: AMBARI-20625 > https://issues.apache.org/jira/browse/AMBARI-20625 > > > Repository: ambari > > > Description > ------- > > Added `-Xlint:all` flag. Currently this has effect only on `ambari-server` > module. > > > Diffs > ----- > > dev-support/test-patch.sh 661f871c6cce927688f17d1aa77aba37eae9bbe6 > > > Diff: https://reviews.apache.org/r/58083/diff/1/ > > > Testing > ------- > > Tested with patch that increased the number of warnings, got: > > ``` > {color:red}-1 javac{color}. The applied patch generated 496 javac > compiler warnings (more than the trunk's current 494 warnings). > ``` > > > Thanks, > > Attila Doroszlai > >
