----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58073/#review170863 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On April 3, 2017, 2:02 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58073/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 2:02 p.m.) > > > Review request for Ambari, Attila Magyar, Dmitro Lisnichenko, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-20632 > https://issues.apache.org/jira/browse/AMBARI-20632 > > > Repository: ambari > > > Description > ------- > > Pattern > ``` > while not queue.empty(): > queue.get(False) > ``` > does not work well, because .empty() call often returns True while there are > still some items in queue. Added checking queue size(.qsize()) and some > guards not to block too long in read function if queue is really empty but > .empty() and .qsize() returning false information. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 04a3e85 > ambari-agent/src/main/python/ambari_agent/main.py 923c570 > > > Diff: https://reviews.apache.org/r/58073/diff/2/ > > > Testing > ------- > > mvn clean test, manual tests to check if queues really drained fast enough. > > > Thanks, > > Eugene Chekanskiy > >
