----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58148/#review170877 -----------------------------------------------------------
Fix it, then Ship it! Just the wording change. Hopefully, it's as easy as a few search/replaces, especially since you broke them out by <message/> tag (nice!) ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml Lines 665-669 (patched) <https://reviews.apache.org/r/58148/#comment243738> Let's make this a little more fluent/user-friendly: ``` You can now remove any HBase snapshots which were created at the beginning of the upgrade. To see existing snapshots, use the following HBase shell command: hbase> list_snapshots Once you have found an existing snapshot which you would like to remove, you can use the following command: hbase> delete_snapshot 'snapshotName' ``` - Jonathan Hurley On April 3, 2017, 10:23 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58148/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 10:23 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-20663 > https://issues.apache.org/jira/browse/AMBARI-20663 > > > Repository: ambari > > > Description > ------- > > During our upgrades we make a Hbase snapshot. When we finalize our upgrades > we ask user to delete them. Otherwise users can find hbase snapshots that > were very old just lying around from an older upgrade. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 396bf3057d > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > b95bae5bb4 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 22f277e36f > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > dfcd29f547 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > 6bf2d4c524 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml > 61c05bd9ff > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 365022dbad > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml > 27d00599b2 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > 1e6c18a310 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > dace92116b > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > 7fda46a87c > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml > 708c0117d2 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > fdcc368b9e > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > 40784aa7ea > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > e7ada04cb1 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > 9139760232 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml > a030adb9d0 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml > c226492831 > > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml > 035cb59fda > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml > 458667d7b3 > > ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml > 2626bc3cfe > ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml > 99746d695a > > > Diff: https://reviews.apache.org/r/58148/diff/1/ > > > Testing > ------- > > mvn clean test > live cluster test > > > File Attachments > ---------------- > > Screenshot from 2017-03-31 22_16_35.png > > https://reviews.apache.org/media/uploaded/files/2017/04/03/a336bede-1d0f-4aed-8f4d-2e34986f0c4c__Screenshot_from_2017-03-31_22_16_35.png > > > Thanks, > > Dmitro Lisnichenko > >
