----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58153/#review170902 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On April 3, 2017, 5:42 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58153/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 5:42 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor > Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19149 > https://issues.apache.org/jira/browse/AMBARI-19149 > > > Repository: ambari > > > Description > ------- > > Replace string concatenation within `append()` calls with chained `append()`. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > cca279b66eb4b5568169d49c66a95bb4d672de3a > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 537b9936e33cc9c2f714f8fe23f8232c0ca0d837 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequest.java > 6fdac2f32cc2044688961f80b7981d34f3d6e9f3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java > b3a2def043df46efa16b6f4a9c7609c3e064a1c4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java > 351974a481d4b25a10283a6585a9d53e63755430 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java > a8e6315f1ef44cd7719e65f31278254e85c1ba2a > > ambari-server/src/main/java/org/apache/ambari/server/controller/ShortTaskStatus.java > 975476f9d3e6d7e024546bdfc16450e95a0d36a1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java > 282131a93b69ed8da8105298fc8264c64410eecb > > ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionManager.java > 7a2738b8cef9b43438df593c2af3fa89a952496e > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java > ad18428d043e026d7c90f30767d70576d87c2aa8 > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphNode.java > d2aac3c8e92e13252fd2aab6f9a3d7e75c2bba73 > ambari-server/src/main/java/org/apache/ambari/server/state/HostConfig.java > f95d843b78f46da2be2bf87f95740ecca3339aa2 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 515cc63f740b4673c371573716cde9f3748dbb82 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 9caff6a74554bf774cd2d2d38ac632a9812546a8 > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > f994457f930b1e2a21e119f32f79d3b546ec09c8 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java > 5ef71174146a681689538080fd463fae8bf066ae > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java > 5d2e605339147b67c410725e41d52f1117403d74 > > > Diff: https://reviews.apache.org/r/58153/diff/1/ > > > Testing > ------- > > ``` > $ mvn -am -pl ambari-server clean test > ... > Tests run: 4978, Failures: 0, Errors: 0, Skipped: 39 > ... > [INFO] BUILD SUCCESS > ``` > > > Thanks, > > Attila Doroszlai > >
