----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58198/#review171129 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py Lines 129-131 (original), 129-131 (patched) <https://reviews.apache.org/r/58198/#comment244017> There should be a test to cover this case. - Nate Cole On April 5, 2017, 1:52 a.m., zhangxiaolu zhangxiaolu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58198/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 1:52 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro > Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-20675 > https://issues.apache.org/jira/browse/AMBARI-20675 > > > Repository: ambari > > > Description > ------- > > the method of install_snappy is repetitive in hdfs.py > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 1264284 > > > Diff: https://reviews.apache.org/r/58198/diff/1/ > > > Testing > ------- > > done it > > > Thanks, > > zhangxiaolu zhangxiaolu > >
