> On April 6, 2017, 11:06 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > > Lines 306 (patched) > > <https://reviews.apache.org/r/58228/diff/2/?file=1685791#file1685791line308> > > > > From my experience, I've seen several cases where deleting records from > > the execution command, HRC, stage, request, etc. table also requires > > deleting records from the toplogy* tables. > > > > Otherwise, Ambari still thinks that the cluster is still being deployed > > via blueprints and causes a lot of problems with configs. > > > > Have you tested this in actual clusters deployed via BP and that have > > undergone EU/RU? > > Vitalyi Brodetskyi wrote: > Nope, i tested it on cluster deployed with UI. Please take a look at new > patch exactly on RequestDAO.cleanup() method. I've added there comments with > clarification. As we discussed earlier we don't want to touch Upgrade, so i'm > excluding stages and requests that i found in Upgrade tables. I tested it and > looks like it works fine (populated Upgrade tables manually). But i'm not > sure how will work cluster with BP, we really removing some rows from BP > tables, need to check.
I'm ok with not deleting from the upgrade table, but we have to be very careful since that has a FK request_id. In my opinion, we definitely need to be able to delete requests that used to belong to an upgrade. For large clusters, those request, stage, HRC records are going to easily be 100k rows. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58228/#review171264 ----------------------------------------------------------- On April 6, 2017, 11:26 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58228/ > ----------------------------------------------------------- > > (Updated April 6, 2017, 11:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav > Papirkovskyy, and Sid Wagle. > > > Bugs: AMBARI-20687 > https://issues.apache.org/jira/browse/AMBARI-20687 > > > Repository: ambari > > > Description > ------- > > Add check for large tables into db consistency check. > Add code to cleanup these tables into db-cleanup code. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > e7e9433 > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java > c132a3d > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > 1dd3b54 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > 79b8bc9 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 2696f66 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > c2919b2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java > 85f3a25 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > a809295 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > f19aa72 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java > ff14e3a > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java > 8ee41d2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java > 3386c24 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java > d035729 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java > b90e192 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java > c71d4e4 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 89574bc > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java > 560970a > ambari-server/src/main/python/ambari-server.py 87cc6c2 > ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > 7d8ba50 > > > Diff: https://reviews.apache.org/r/58228/diff/4/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
