----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57610/#review171474 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 3042 (patched) <https://reviews.apache.org/r/57610/#comment244415> Caching these properties is a good idea, but I think we should be able to handle multi clusters, so keep theese properties separatly for each cluster and ideally these should be cached only for the time of export, since next time the state of the cluster may change. We don't have such filters yet, may be we can cache theese props in a HashMap by clusterId, in ThreadLocal and an init method to PropertyFilter where we can reset this map prior beginning the export. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 3048 (patched) <https://reviews.apache.org/r/57610/#comment244411> Please use slf4j Logger here - Sandor Magyari On April 5, 2017, 4:56 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57610/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 4:56 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, Robert Nettleton, and Sandor > Magyari. > > > Bugs: AMBARI-20366 > https://issues.apache.org/jira/browse/AMBARI-20366 > > > Repository: ambari > > > Description > ------- > > If blueprint is exported from a kerberos enabled cluster Kerberos rules > export principal names which contain cluster name and Realm, this exports > existing cluster name and realm name as tokens and replaces those tokens with > new values of cluster name and realm during successive cluster deployments. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > db1aa074d4 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java > 13db5f8b56 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > dba40437ae > > > Diff: https://reviews.apache.org/r/57610/diff/2/ > > > Testing > ------- > > Tested manually. > Modified test cases. > > > Thanks, > > Amruta Borkar > >
