-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58371/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Sangeeta Ravindran, and Tim Thorpe.
Bugs: AMBARI-20737
https://issues.apache.org/jira/browse/AMBARI-20737
Repository: ambari
Description
-------
The Register Version UI page on Ambari Admin View shows two options related to
adding repo URLs: Use Public Repository and Use Local Repository.
The Use Public Repository is disabled when no stack repos are marked as
"stack_default=false" ( meaning it;s from the stack/repo URL defined in the
"latest" section in the repoinfo.xml)
When repoinfo.xml does not have the latest section, however, the Use Public
Repository should be hidden from the view as it'd be definitely no non-default
stacks, and the "Why is this disabled ?" explanation does not make sense in
this case.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
b3c27dc
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js
e028906
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
3bee2a1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
352aa2d
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
507c560
Diff: https://reviews.apache.org/r/58371/diff/1/
Testing
-------
unit tests
patched a trunk cluster with the change, when all repoinfo.xml from all stacks
do not have the "latest" section, the Use Public Repository radio button is
hidden. When at least one repoinfo.xml has the "latest" section, the Use Public
Repository radio button is shown.
Thanks,
Di Li
