> On April 11, 2017, 2:05 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java > > Lines 31 (patched) > > <https://reviews.apache.org/r/58363/diff/1/?file=1688843#file1688843line31> > > > > Can we shorten this to "is_background"? > > Nate Cole wrote: > +1 for this suggestion.
Sure - I'll change the SQL as well and update the patch. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58363/#review171591 ----------------------------------------------------------- On April 11, 2017, 12:52 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58363/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 12:52 p.m.) > > > Review request for Ambari, Nate Cole and Robert Levas. > > > Bugs: AMBARI-20714 > https://issues.apache.org/jira/browse/AMBARI-20714 > > > Repository: ambari > > > Description > ------- > > Create a new UpgradeCatalog for v2.5.1 and add the DB changes in AMBARI-20712 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > 590a3e8 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58363/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
