> On April 11, 2017, 6:42 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py > > Lines 48 (patched) > > <https://reviews.apache.org/r/58297/diff/3/?file=1687921#file1687921line48> > > > > Generally, add documentation to all classes and functions.
added in another patch - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58297/#review171604 ----------------------------------------------------------- On April 11, 2017, 10:57 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58297/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 10:57 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sid Wagle. > > > Bugs: AMBARI-20721 > https://issues.apache.org/jira/browse/AMBARI-20721 > > > Repository: ambari > > > Description > ------- > > As for registering and heartbeat we still require synchronious behaviour on > agent side. This requires a dictionary with blocking pop with correlationId > as keys. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00 > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION > ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9 > > ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py > PRE-CREATION > > ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/listeners/__init__.py > PRE-CREATION > ambari-agent/src/main/python/ambari_agent/security.py 45de7bb > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > 983b392 > > ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json > PRE-CREATION > ambari-common/src/test/python/coilmq/server/socket_server.py b4f081e > > > Diff: https://reviews.apache.org/r/58297/diff/3/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
