-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58385/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor
Magyari, and Sebastian Toader.
Bugs: AMBARI-19149
https://issues.apache.org/jira/browse/AMBARI-19149
Repository: ambari
Description
-------
* Members of interfaces are always `public`.
* Constructors of enums are always `private`.
* Member interfaces and enums are implicitly `static`.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
a8b89a9e374ca35c7ae049aa5789d4c6a5f8bf1e
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
b0550c01381e635ee90d58ab26030cb6fc89f56d
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
0d1ef13c211a35b4107eea7c8e4eaf69bfde7557
ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
8faa2a1ae04d9d04d2d8a54fb0cd80f1e285c2f8
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/RequestHandler.java
9e2d92327ccd6888bace2a97d03bbbd5c9ba7981
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/Expression.java
206f2676cf57cb48b5ea0824c02a3fb17ed86106
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LogicalOperator.java
8881aadfc6555460fef33a3e7d056b3a4dc4549e
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/Operator.java
f9c3acce332b490c199e9e8879821c3e547c8d5c
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/RelationalOperator.java
cbcba0caaf27b1388e4429a5fa3c76162cd0018c
ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java
8ac38ac29a992d3ccdb7fa3a1d4e4668e06893f5
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/Renderer.java
b71d96fffed15d7b6a4f0746efa976656929d8b9
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstance.java
3695807a767f2b56a5895ffa6769c99491660a29
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactory.java
0b5859b251fa0bbed35a68d239dafdf85eda1be6
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessor.java
ab25bb21bcc3c8f56dff7cd2c20634b1ab65d809
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
6284879a02d8c73027e64eb62a1ee93287fc25d4
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
dc16b3e2e7b378c4a89341a61feab0bb2226b16b
ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManager.java
9a8b677e99f7bd5f3eaee7a0e2fb8698fae48d9c
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
f5677c1a71c84f9caf96ec6d58bc6c9c73de6b8e
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java
5aa1ea9d69871452b99c389af0cbc5c4c4d2c70e
ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNode.java
60d365ffc3e0f56272e52bfdf56f421caae9b30b
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
67cf4f1a805ee58863a2d0f82886feb5b7750e00
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
a8bfbf0ddc4160591a07d8ccca6172b8afc7adbb
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
91bfe09debd414fe63a365c15d8e94823495164d
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
d0005719a2b01c1c319782cd77b49a01b2454d5c
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
f72f476d21466eaaae9dc1a6751490bdfc5ea2aa
ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerStateProvider.java
aef907c72f95495f9c9f8bbb199d989e841e1c8b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
01cf79a521aef3922690477cfc076d4ab73197f9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
a6a731c2714b3ada1b28031dd4940e49b660f595
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
88a8f808bb66c2f48a65f0f36f2a96592fdc99e4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
2c5741f2542d24da797ef6db9242ae23490b0ea9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ObservableResourceProvider.java
c0c1dc483d5f9c7345a15af21fb610bb2a15d838
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceProviderObserver.java
a5dd3df0408c1e666f5ff8fe360ba7e1fa7c6b84
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java
32b7fec040d5d12deffc94319d54c33965167272
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java
a40f1650b410d38864e0612cd997547627ad1bbd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java
a3d3ab50b7491d0b52810e27d6657d0aae8b2863
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java
9737aaae603e23ece59f4b4e688c5945ab0f71b1
ambari-server/src/main/java/org/apache/ambari/server/controller/ivory/IvoryService.java
aeeed0a6b540cd38ac9e6a01cce7d0d620697a38
ambari-server/src/main/java/org/apache/ambari/server/controller/jdbc/ConnectionFactory.java
c8444b1e939e6582e1d50d8ebca9ee2e170a9b50
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
bffe600a51eef0c5ac245408eea474cfdc4e1eac
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
7833e01492f761baee59d678069d3f425b32f844
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricHostProvider.java
8f1fc8e716388225cf0181b4dd7ed89d1aaf8882
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java
2fb2f182409edb9edfdb2a1917e446938aa6fcc4
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsServiceProvider.java
f9f9dc68c35674b9d866d83ad5f6c25d5448e6f9
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/BasePredicate.java
9b3fbfec383663c229d017e307efe9f6f41f9312
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/PredicateVisitor.java
3316a009f54b9b4169607989c285a07b5689f634
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/PredicateVisitorAcceptor.java
6af2cb8da3c0f1faa6a5a2b5e8d14d1643b698e6
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ExtendedResourceProvider.java
134ff2c46acb4af7086447922ce773116e526df7
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/PageRequest.java
bb30ac2f9ad69e76aa9975e3accaa6e139bb501d
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/PageResponse.java
9e4d6ab6a81a020d6cee50725ff4b9520eb7eaa7
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Predicate.java
ae24b069cceda14a8a984d745937c37463bad9a3
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/PropertyProvider.java
6829c1bb25d89bab9ab44a9bc73412718bbaed03
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ProviderModule.java
33dfc24067175920bbf602dc3c7d94a1738d7444
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/QueryResponse.java
66bd3b01f07013bb7e7ce1b7f9e3c8f711fe7abb
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/RequestStatus.java
0ebf93afab451862b8fef6ef747f5de8ad260e72
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourcePredicateEvaluator.java
425ef456bd631c7e2e9ccd5c43d1cb12bc0daebb
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Schema.java
bcb3291291c7733aba12286872228547a910db24
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/SchemaFactory.java
290b508c81151da0e029802e7aa8aad15d5f8245
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/SortRequest.java
9f7f6ab8eab2c9bbc0f36ef90feb04abfa464ffc
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/StreamProvider.java
098393f3946943bee0d4868db5572743b14cedc5
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCallback.java
e4e944d28bfc91f1e06a32944dfa74142d4c0823
ambari-server/src/main/java/org/apache/ambari/server/orm/JPATableGenerationStrategy.java
9316c1018289cd24ed501191bbabe4da22ed1a74
ambari-server/src/main/java/org/apache/ambari/server/orm/cache/ConfigGroupHostMapping.java
ae3f0766d52a0c8cf3b623e715a6fe3de97c5fc8
ambari-server/src/main/java/org/apache/ambari/server/orm/cache/HostConfigMapping.java
d5afc1581ca1986bc8ac73524ca6486128fdadf4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfiguration.java
36dde730d74258a4203405b8b1dde1730e214305
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionJob.java
ff83729c9ee8347d88088717418862f8ee4dbd43
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduler.java
bb0a6c065b03645abe1012e6f3ad457f8a209035
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityHelper.java
d4fdcf5f58183ea8d559f5a7b5f95f4609fab71d
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/ResourceType.java
40a10e96378133c28e67e915b1e0b1df93a16190
ambari-server/src/main/java/org/apache/ambari/server/security/encryption/MasterKeyService.java
895b8a391c3a8758e6f74f690f74a763e14be6f0
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFile.java
82b92259f9093110d45c17df8da46fbe37c3f44b
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
3c14627ccc7e80f86e880125cb0e8d93f785a365
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationInfo.java
f8a19ac18e5758f326c8e60894c8f468d16c4f7e
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionModule.java
c5ce9763882c76f16ac65a8e418190564454b8e4
ambari-server/src/main/java/org/apache/ambari/server/stack/Validable.java
0a557b46f436e3a45948a0a647bc54254eb142ce
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
959480311b7a0435032bf0a5f130810a091604fd
ambari-server/src/main/java/org/apache/ambari/server/state/CommandScriptDefinition.java
cee55fa3c838f860e367918b27c18f6e60fe7784
ambari-server/src/main/java/org/apache/ambari/server/state/Config.java
67570f41eedf2d73399d028b19068fafa5117ce7
ambari-server/src/main/java/org/apache/ambari/server/state/HostHealthStatus.java
fb8fe960f88e0c5875fbe75728f3ed6393a060c2
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
5a8c25e770f0a906ea4fee611f4f34b9c877669e
ambari-server/src/main/java/org/apache/ambari/server/state/action/Action.java
6d00813cd6848a27dd520c985857661b850bf3fa
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroup.java
5a9c5741ba4842970ba9eaa3e52b18810f1142e3
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/MultipleArcTransition.java
b4c688ff2d8ba8d481ad315c02c0f228812663a4
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/SingleArcTransition.java
c802e2a59584bf724f26a4c6af9ecbbae8ac37a1
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/StateMachine.java
e8e28133976fa0e4281e0f2e1839baa4523f340c
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
9b1fd6b563b163a73497bf830171a2c42d37839b
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/RequestExecution.java
8a325f46ad0b740f0154aac44149bb01758460c5
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeFunction.java
d58316d032fd4c5548c6ec260a4c678eaa3d3884
ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java
346268f236b8a2c09ed7376bc5ca7ec743150fdc
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
40fa2d3eddd5df705cb99e0090520854d8c9d258
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
206d161fc694f67ae982ef668c5057b4bacec59b
ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroup.java
43539635de76841f2a4fe2724e873e415bc7e726
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
516ea143fbc9c4ea1bf01fbe6fdf925eae40574f
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequestFactory.java
e78c5e0e3e1bfec1a0201d89d125bc790a6b1e1d
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
146b42411b5a7ac11e458c4b4d504e3653a64f0e
ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/TopologyTask.java
0753c3da22241fbcc877843b1ca2e9bd8f2ad763
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
3e1d3b80a00e6afde9ce580e1f1a027fc943ce0b
ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceHandlerList.java
8d2b52a5c8c7be8cfee9d585ca4a998bf16b05c1
ambari-server/src/main/java/org/apache/ambari/server/view/persistence/SchemaManagerFactory.java
ae730d109ca04b385f1220db5070316272bd8700
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractJDBCResourceProviderTest.java
f546aabab7f14d18be19b6e25c3323d7f50133fb
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
1e746583a49bdc3b3aa11a4c64d03f8101109695
ambari-server/src/test/java/org/apache/ambari/server/upgrade/SectionDDL.java
bdb8cd96f323c5b032a9c112fc9871e2fd76680b
Diff: https://reviews.apache.org/r/58385/diff/1/
Testing
-------
Code compiles fine:
```
$ mvn -am -amd -pl ambari-server -DskipTests clean test
...
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
