> On April 12, 2017, 7:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/58277/diff/5/?file=1691001#file1691001line82>
> >
> > I don't see this being used anywhere.
It is used in
~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
stack_version_buildnum =
get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
-----------------------------------------------------------
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and
> Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom services do not advertise any version and hence will not
> participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -----
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> 79393b985f
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> 02ae62daf3
>
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> ff00a1f38e
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> 0d1ef13c21
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> d5018f55b2
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 751ce085d8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
> e42bd45cc1
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> ad668a2051
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
> 872120cc55
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
> 1609050409
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
> 71a02f5e5a
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
> 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> -------
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine,
> Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
