----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58409/#review171856 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On April 13, 2017, 4:16 a.m., Yuanbo Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58409/ > ----------------------------------------------------------- > > (Updated April 13, 2017, 4:16 a.m.) > > > Review request for Ambari, Di Li and Tim Thorpe. > > > Bugs: AMBARI-20754 > https://issues.apache.org/jira/browse/AMBARI-20754 > > > Repository: ambari > > > Description > ------- > > get_value_from_jmx of jmx.py is used in getting NameNode HA state. As we > know, if the cluster is large, it takes a long time for Namenode to leave > safe mode when restarting Namenode, thus we use retry mechanism to invoke > get_value_from_jmx in case of getting wrong state. The problem is that, > get_value_from_jmx will print several exception message into std_error during > retrying, it confuses users because there're error messages in std_error, > while all the services restart successfully > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/jmx.py > 9a4ff5f > > ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py > 665a8e4 > > > Diff: https://reviews.apache.org/r/58409/diff/1/ > > > Testing > ------- > > > Thanks, > > Yuanbo Liu > >
