----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58420/#review171889 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On April 13, 2017, 3:59 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58420/ > ----------------------------------------------------------- > > (Updated April 13, 2017, 3:59 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-20746 > https://issues.apache.org/jira/browse/AMBARI-20746 > > > Repository: ambari > > > Description > ------- > > Change to warning log if Ambari doesn't have baseurls for Install Packages > step before EU/RU. It currently prints out as an INFO that can be easily > ignored. Since we don't fail the Install Packages step when the baseurls are > empty, we should at least change the logging level to warning. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 92e72ed > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > 8f2d4e6 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 112abe3 > > > Diff: https://reviews.apache.org/r/58420/diff/2/ > > > Testing > ------- > > patch a trunk cluster with the change, run Install step before the EU/RU > > > Thanks, > > Di Li > >
