----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58426/#review172079 -----------------------------------------------------------
Ship it! Ship It! - Sandor Magyari On April 13, 2017, 5:14 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58426/ > ----------------------------------------------------------- > > (Updated April 13, 2017, 5:14 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor > Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19149 > https://issues.apache.org/jira/browse/AMBARI-19149 > > > Repository: ambari > > > Description > ------- > > Code changes sometimes leave dangling references in Javadoc comments. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > a46e6a2edc6357efa65620c3827b4075f0514978 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java > 43c484c13f730d244b56c8a9ac11d707103e2292 > > ambari-server/src/main/java/org/apache/ambari/server/api/query/JpaSortBuilder.java > 6d769457d45695557f3b66612db8dae1b77caf37 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RequestScheduleResourceDefinition.java > 6de5e25bbd384e30f5d9c0273161447467338885 > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/BootStrapResource.java > 4aad5305339a85773d00dd4b421d9a606c0c62a8 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java > d3f88ec5c71fecf9e76233bb3249dd36559ebdeb > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java > 05f3e91c25018096ed0df17a9b3c81edc00c9310 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 6f592f0db56c43626404b301b8cfd4bac6b10224 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 27ac03e4932a743b1c64828429a2928dd5df855c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 511c8fb41f129024d5019284359ad0b22c77514b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > 352aa2d3eb25b13b8a578e73310240a293c17ae5 > > ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDisabledEvent.java > a3c6e6861dc6ec5d1ade21ad897ab56d42cc5dc6 > > ambari-server/src/main/java/org/apache/ambari/server/events/jpa/EntityManagerCacheInvalidationEvent.java > fe472b2f8997eb4d6d68e7cd37929c3bf3127460 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java > 907e4d82306a4a3edc319c4a5166b80f951a50a0 > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java > ae07dc0f6fb1360ece3a896e3d86111c7d7a205c > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionDAO.java > 6c6c3aed977a2fa5251b59b08a561c321f560956 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java > e860c6470b44b2bd6f9005b2aaf142fca85a51da > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 5d53416035ffecb11dcda2082df3a4207be402e9 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java > 63374877ee8cfdb7e16a2f88306588fec4a79f6d > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > bea1d1900552f4338821bb38c4aea20b0c6284d8 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeGroupEntity.java > 4830e3b11bd955c38afe27f50491889b4fcaf26c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewURLEntity.java > 27cb8e286531e957e2c238c987d8e3d1de09ebd6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java > c2778d38fcace9eea82df890844b7db2bdc68d83 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java > e06d8f24a60c662a839c69fba9ea2e569b654e2d > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > dfe70728cd83070408e1e0d117b32c83c77b470a > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > c9619954923ea573a9d97e4178a6721860258bbf > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 543dadd3f9a4aebb80327be6c3c76eb924602f6a > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java > 616bcdbf0ebc0ea25e86f472be55240b9e5293b7 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > b7cc4cd7bfcbe14803514753f7eed8d0dfa009c2 > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupFactory.java > 906d9483c598a51895f5118f12fa2f9b2ca7e125 > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java > 89a03aa4d27e2e3a3e1197d9d7c1c43b746f9799 > > ambari-server/src/main/java/org/apache/ambari/server/state/fsm/StateMachineFactory.java > cc57f2c0d0ba6021f0c30a10fa8bb126f1a2d88d > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > 69399d6c140c2490b44b1e58a9a160513206bcdb > > ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java > 59ec15bc1101e79ab6a2f394669cb82bd461a6a4 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > 97864a67da23cb4c1799bd090a3dbee53cff550e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java > dfa61591b8fe034a5eba176d42a5dcd1c67662b1 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 8a4afe98ca76157cf1b8da96268b8002f0725ea9 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/JpaSortBuilderTest.java > 394de9f1cb67c42fa1b1289a1044f37d64cd3e74 > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > 98510db0c3b6e65ef5fc5a4a11b50129e145dfb7 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 8e50b5f86f9a28e80d3428e3884f2bbc9b5a8822 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAOTest.java > d5fa79346539ca5a7d2483af8112e385343ca050 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java > 62fc19e21031b1a36112f56624b928cb41157bdb > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java > e50dba5a92e6bfdae97dcd31d905541900aad620 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java > 483aac504ae1ff3016aee5c9d6a3dbf1cc89ca65 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 345c463cd32a3a6411aae37c3b61aabbb5440384 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java > e13dd708f6008033942c78bff063b3068ff3e923 > > > Diff: https://reviews.apache.org/r/58426/diff/1/ > > > Testing > ------- > > "Declaration has problems in Javadoc references" inspection in IDEA (only 7 > items left). > Code compiles fine. > > > Thanks, > > Attila Doroszlai > >
