-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58437/#review172094
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
Lines 28 (patched)
<https://reviews.apache.org/r/58437/#comment245169>

    Please also include these changes for YARN 3.0



ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
Lines 194 (patched)
<https://reviews.apache.org/r/58437/#comment245170>

    Please also include this logic for YARN's Service Advisor in 3.0



ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
Lines 254 (patched)
<https://reviews.apache.org/r/58437/#comment245168>

    Description here seems incorrect. Also document that this is allowed to 
return None.


- Alejandro Fernandez


On April 13, 2017, 11:08 p.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58437/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 11:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20763
>     https://issues.apache.org/jira/browse/AMBARI-20763
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In 2.6, update the following YARN configs related to ATS:
> 
> - **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster 
> initialization/creation based on host memory.
> - **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation 
> and/or (2). when a change is detected in value for 
> 'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
>    
>   ats_heapsize = long(min(math.floor(host_mem/2), 
> long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
>  d04c3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 53ff007 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 8576dcc 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 5bfa1a9 
> 
> 
> Diff: https://reviews.apache.org/r/58437/diff/2/
> 
> 
> Testing
> -------
> 
> Yes, 
> 
> - Python UTs added.
> - Tested on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to