> On April 19, 2017, 5:31 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > > Lines 402 (patched) > > <https://reviews.apache.org/r/58492/diff/1/?file=1693587#file1693587line402> > > > > We need to be really careful here since technically those are versions > > of the NiFi stack when those services are added on top of the HDP stack, > > which is confusing. > > > > I don't think these should be added to this file.
Madhu, the min_version should be HDP-specific. Since NIFI will be added to only HDP-2.6, you should set the min_version to 2.6.0.0. Alejandro, ideally we should have service features triggered based on service versions, but we dont have that functionality yet and hence the current approach. In Ambari 3.0 this would change. - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58492/#review172373 ----------------------------------------------------------- On April 19, 2017, 5:25 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58492/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 5:25 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit > Mohanty. > > > Bugs: AMBARI-20778 > https://issues.apache.org/jira/browse/AMBARI-20778 > > > Repository: ambari > > > Description > ------- > > Add following properties to stack_Features.json > { > "name": "nifi_encrypt_config", > "description": "Encrypt sensitive properties written to nifi property > file", > "min_version": "2.1.0.0" > }, > { > "name": "toolkit_config_update", > "description": "Support separate input and output for toolkit > configuration", > "min_version": "2.1.0.0" > }, > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 34f3c0769c > > > Diff: https://reviews.apache.org/r/58492/diff/1/ > > > Testing > ------- > > > Thanks, > > Madhuvanthi Radhakrishnan > >
