-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/
-----------------------------------------------------------
Review request for Ambari, Di Li and Tim Thorpe.
Bugs: AMBARI-20616
https://issues.apache.org/jira/browse/AMBARI-20616
Repository: ambari
Description
-------
Some services in our stack have custom commands where the name is a combination
of an operation and a component name.
For e.g. <name>Remove_Logical_myservice_mycomponent</name>
When the custom command is being executed, the operations window title is
displayed as "Remove Logical myservice mycomponent mycomponent"
It would be useful to provide an optional attribute e.g. useNameInOps for
custom commands to allow using the command name itself as the title displayed
in the operations window.
<customCommand>
<name>Remove_Logical_myservice_mycomponent</name>
<useNameInOps>true</useNameInOps>
<commandScript>
<script>scripts/mycomponent.py</script>
<scriptType>PYTHON</scriptType>
<timeout>10800</timeout>
</commandScript>
</customCommand>
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
87a6edf
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
17bc718
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
20b0417
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
86feceb
ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
280a59b
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
633d837
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d
ambari-server/src/main/resources/properties.json c2545fe
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
8a52b8a
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
fec041c
ambari-web/app/controllers/wizard/step9_controller.js 4697dad
ambari-web/app/utils/ajax/ajax.js 2b5e52a
ambari-web/app/utils/helper.js 03a2e82
ambari-web/app/utils/host_progress_popup.js c615cae
ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252
ambari-web/test/utils/helper_test.js 4b9ec36
Diff: https://reviews.apache.org/r/58590/diff/1/
Testing
-------
Manual Testing.
Added new test cases.
Thanks,
Sangeeta Ravindran
